asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #24654 from groud/better_dragging_autoscroll

Browse source 
Enhance tree scrolling when dragging
This commit is contained in:
Rémi Verschelde 2019-04-15 10:35:08 +02:00 committed by GitHub
commit 39c5f363f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
editor/editor_themes.cpp
View file

@ -687,7 +687,7 @@ Ref<Theme> create_editor_theme(const Ref<Theme> p_theme) {
theme->set_constant("button_margin", "Tree", default_margin_size * EDSCALE);
theme->set_constant("draw_relationship_lines", "Tree", relationship_line_opacity >= 0.01);
theme->set_constant("draw_guides", "Tree", relationship_line_opacity < 0.01);
theme->set_constant("scroll_border", "Tree", default_margin_size * EDSCALE);
theme->set_constant("scroll_border", "Tree", 40 * EDSCALE);
theme->set_constant("scroll_speed", "Tree", 12);
Ref<StyleBoxFlat> style_tree_btn = style_default->duplicate();

30
scene/gui/tree.cpp
View file

@ -2850,7 +2850,7 @@ void Tree::_notification(int p_what) {
if (p_what == NOTIFICATION_DRAG_BEGIN) {
single_select_defer = NULL;
if (cache.scroll_speed > 0 && get_rect().has_point(get_viewport()->get_mouse_position() - get_global_position())) {
if (cache.scroll_speed > 0) {
scrolling = true;
set_physics_process_internal(true);
}
@ -2897,22 +2897,22 @@ void Tree::_notification(int p_what) {
}
}
if (scrolling) {
Point2 point = get_viewport()->get_mouse_position() - get_global_position();
if (point.x < cache.scroll_border) {
point.x -= cache.scroll_border;
} else if (point.x > get_size().width - cache.scroll_border) {
point.x -= get_size().width - cache.scroll_border;
} else {
point.x = 0;
Point2 mouse_position = get_viewport()->get_mouse_position() - get_global_position();
if (scrolling && get_rect().grow(cache.scroll_border).has_point(mouse_position)) {
Point2 point;
if ((ABS(mouse_position.x) < ABS(mouse_position.x - get_size().width)) && (ABS(mouse_position.x) < cache.scroll_border)) {
point.x = mouse_position.x - cache.scroll_border;
} else if (ABS(mouse_position.x - get_size().width) < cache.scroll_border) {
point.x = mouse_position.x - (get_size().width - cache.scroll_border);
}
if (point.y < cache.scroll_border) {
point.y -= cache.scroll_border;
} else if (point.y > get_size().height - cache.scroll_border) {
point.y -= get_size().height - cache.scroll_border;
} else {
point.y = 0;
if ((ABS(mouse_position.y) < ABS(mouse_position.y - get_size().height)) && (ABS(mouse_position.y) < cache.scroll_border)) {
point.y = mouse_position.y - cache.scroll_border;
} else if (ABS(mouse_position.y - get_size().height) < cache.scroll_border) {
point.y = mouse_position.y - (get_size().height - cache.scroll_border);
}
point *= cache.scroll_speed * get_physics_process_delta_time();
point += get_scroll();
h_scroll->set_value(point.x);