asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

HTTPRequest: Improve response when disconnecting while downloading

Browse source 
Previously if a disconnect occured while downloading a non recoverable error was displayed. This PR attempts to fix this by making sure `request_completed` signal is emitted with an `STATUS_CONNECTION_ERROR` response code.

(cherry picked from commit 70c39737db)
This commit is contained in:
Zak 2020-01-17 20:21:49 +02:00 committed by Rémi Verschelde
parent 1134fade46
commit 3f36ca7323
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
scene/main/http_request.cpp
View file

@ -347,6 +347,9 @@ bool HTTPRequest::_update_connection() {
} }
client->poll(); client->poll();
if (client->get_status() != HTTPClient::STATUS_BODY) {
return false;
}
PoolByteArray chunk = client->read_response_body_chunk(); PoolByteArray chunk = client->read_response_body_chunk();
downloaded.add(chunk.size()); downloaded.add(chunk.size());