asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix heap-use-after-free when converting scene group to global

Browse source
This commit is contained in:
Haoyu Qiu 2024-03-23 19:54:21 +08:00
parent fe01776f05
commit 4848bf4fd8
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
editor/groups_editor.cpp
View file

@ -157,10 +157,14 @@ void GroupsEditor::_update_groups() {
_load_scene_groups(scene_root_node); _load_scene_groups(scene_root_node);
for (const KeyValue<StringName, bool> &E : scene_groups) { for (HashMap<StringName, bool>::Iterator E = scene_groups.begin(); E;) {
if (global_groups.has(E.key)) { HashMap<StringName, bool>::Iterator next = E;
scene_groups.erase(E.key); ++next;
if (global_groups.has(E->key)) {
scene_groups.erase(E->key);
} }
E = next;
} }
updating_groups = false; updating_groups = false;