asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #21882 from DualMatrix/animation_track

Browse source 
Fixed animation_player errors displaying wrong property.
This commit is contained in:
Rémi Verschelde 2018-09-10 19:01:18 +02:00 committed by GitHub
commit 497853c383
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
scene/animation/animation_player.cpp
View file

@ -263,43 +263,36 @@ void AnimationPlayer::_ensure_node_caches(AnimationData *p_anim) {
key.id = id; key.id = id;
key.bone_idx = bone_idx; key.bone_idx = bone_idx;
if (node_cache_map.has(key)) { if (!node_cache_map.has(key))
p_anim->node_cache.write[i] = &node_cache_map[key];
} else {
node_cache_map[key] = TrackNodeCache(); node_cache_map[key] = TrackNodeCache();
p_anim->node_cache.write[i] = &node_cache_map[key]; p_anim->node_cache.write[i] = &node_cache_map[key];
p_anim->node_cache[i]->path = a->track_get_path(i); p_anim->node_cache[i]->path = a->track_get_path(i);
p_anim->node_cache[i]->node = child; p_anim->node_cache[i]->node = child;
p_anim->node_cache[i]->resource = resource; p_anim->node_cache[i]->resource = resource;
p_anim->node_cache[i]->node_2d = Object::cast_to<Node2D>(child); p_anim->node_cache[i]->node_2d = Object::cast_to<Node2D>(child);
if (a->track_get_type(i) == Animation::TYPE_TRANSFORM) { if (a->track_get_type(i) == Animation::TYPE_TRANSFORM) {
// special cases and caches for transform tracks // special cases and caches for transform tracks
// cache spatial // cache spatial
p_anim->node_cache[i]->spatial = Object::cast_to<Spatial>(child); p_anim->node_cache[i]->spatial = Object::cast_to<Spatial>(child);
// cache skeleton // cache skeleton
p_anim->node_cache[i]->skeleton = Object::cast_to<Skeleton>(child); p_anim->node_cache[i]->skeleton = Object::cast_to<Skeleton>(child);
if (p_anim->node_cache[i]->skeleton) { if (p_anim->node_cache[i]->skeleton) {
if (a->track_get_path(i).get_subname_count() == 1) {
StringName bone_name = a->track_get_path(i).get_subname(0);
if (a->track_get_path(i).get_subname_count() == 1) { p_anim->node_cache[i]->bone_idx = p_anim->node_cache[i]->skeleton->find_bone(bone_name);
StringName bone_name = a->track_get_path(i).get_subname(0); if (p_anim->node_cache[i]->bone_idx < 0) {
// broken track (nonexistent bone)
p_anim->node_cache[i]->bone_idx = p_anim->node_cache[i]->skeleton->find_bone(bone_name);
if (p_anim->node_cache[i]->bone_idx < 0) {
// broken track (nonexistent bone)
p_anim->node_cache[i]->skeleton = NULL;
p_anim->node_cache[i]->spatial = NULL;
printf("bone is %ls\n", String(bone_name).c_str());
ERR_CONTINUE(p_anim->node_cache[i]->bone_idx < 0);
} else {
}
} else {
// no property, just use spatialnode
p_anim->node_cache[i]->skeleton = NULL; p_anim->node_cache[i]->skeleton = NULL;
p_anim->node_cache[i]->spatial = NULL;
printf("bone is %ls\n", String(bone_name).c_str());
ERR_CONTINUE(p_anim->node_cache[i]->bone_idx < 0);
} }
} else {
// no property, just use spatialnode
p_anim->node_cache[i]->skeleton = NULL;
} }
} }
} }