asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

add equal checks to Transform3D::looking_at and Transform3D::set_look_at

Browse source
This commit is contained in:
Nathan Franke 2022-07-24 03:14:53 -05:00
parent 72b5a4335e
commit 4b13a6dcb8
No known key found for this signature in database
GPG key ID: 082B90CF10A5B648
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/math/transform_3d.cpp
View file

@ -70,12 +70,18 @@ void Transform3D::rotate_basis(const Vector3 &p_axis, real_t p_angle) {
} }
Transform3D Transform3D::looking_at(const Vector3 &p_target, const Vector3 &p_up) const { Transform3D Transform3D::looking_at(const Vector3 &p_target, const Vector3 &p_up) const {
#ifdef MATH_CHECKS
ERR_FAIL_COND_V_MSG(origin.is_equal_approx(p_target), Transform3D(), "The transform's origin and target can't be equal.");
#endif
Transform3D t = *this; Transform3D t = *this;
t.basis = Basis::looking_at(p_target - origin, p_up); t.basis = Basis::looking_at(p_target - origin, p_up);
return t; return t;
} }
void Transform3D::set_look_at(const Vector3 &p_eye, const Vector3 &p_target, const Vector3 &p_up) { void Transform3D::set_look_at(const Vector3 &p_eye, const Vector3 &p_target, const Vector3 &p_up) {
#ifdef MATH_CHECKS
ERR_FAIL_COND_MSG(p_eye.is_equal_approx(p_target), "The eye and target vectors can't be equal.");
#endif
basis = Basis::looking_at(p_target - p_eye, p_up); basis = Basis::looking_at(p_target - p_eye, p_up);
origin = p_eye; origin = p_eye;
} }