asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GDScript: Infer type with string format operator

Browse source 
If the left value type is known to be String, assume the format operator
(`%`) will return a string, since it works with any type in the right
hand side. This is also used by type inference even if the right hand
type is unknown at compile time.
This commit is contained in:
George Marques 2024-04-09 15:49:44 -03:00
parent a7b860250f
commit 4bdba718c5
No known key found for this signature in database
GPG key ID: 046BD46A3201E43D
3 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/gdscript/gdscript_analyzer.cpp
View file

@ -2846,6 +2846,11 @@ void GDScriptAnalyzer::reduce_binary_op(GDScriptParser::BinaryOpNode *p_binary_o
result.type_source = GDScriptParser::DataType::ANNOTATED_EXPLICIT; result.type_source = GDScriptParser::DataType::ANNOTATED_EXPLICIT;
result.kind = GDScriptParser::DataType::BUILTIN; result.kind = GDScriptParser::DataType::BUILTIN;
result.builtin_type = Variant::BOOL; result.builtin_type = Variant::BOOL;
} else if (p_binary_op->variant_op == Variant::OP_MODULE && left_type.builtin_type == Variant::STRING) {
// The modulo operator (%) on string acts as formatting and will always return a string.
result.type_source = left_type.type_source;
result.kind = GDScriptParser::DataType::BUILTIN;
result.builtin_type = Variant::STRING;
} else if (left_type.is_variant() || right_type.is_variant()) { } else if (left_type.is_variant() || right_type.is_variant()) {
// Cannot infer type because one operand can be anything. // Cannot infer type because one operand can be anything.
result.kind = GDScriptParser::DataType::VARIANT; result.kind = GDScriptParser::DataType::VARIANT;

6
modules/gdscript/tests/scripts/analyzer/features/infer_type_on_string_format.gd Normal file
View file

@ -0,0 +1,6 @@
# GH-88082
func test():
var x = 1
var message := "value: %s" % x
print(message)

2
modules/gdscript/tests/scripts/analyzer/features/infer_type_on_string_format.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_OK
value: 1