asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #81383 from AThousandShips/valid_remove

Browse source 
Remove unnecessary validity checks from `Button` and `TextureRect`
This commit is contained in:
Rémi Verschelde 2023-09-07 13:53:20 +02:00
commit 4bf3de7853
No known key found for this signature in database
GPG key ID: C3336907360768E1
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
scene/gui/button.cpp
View file

@ -554,10 +554,8 @@ void Button::set_icon(const Ref<Texture2D> &p_icon) {
} }
void Button::_texture_changed() { void Button::_texture_changed() {
if (icon.is_valid()) { queue_redraw();
queue_redraw(); update_minimum_size();
update_minimum_size();
}
} }
Ref<Texture2D> Button::get_icon() const { Ref<Texture2D> Button::get_icon() const {

6
scene/gui/texture_rect.cpp
View file

@ -189,10 +189,8 @@ bool TextureRect::_set(const StringName &p_name, const Variant &p_value) {
#endif #endif
void TextureRect::_texture_changed() { void TextureRect::_texture_changed() {
if (texture.is_valid()) { queue_redraw();
queue_redraw(); update_minimum_size();
update_minimum_size();
}
} }
void TextureRect::set_texture(const Ref<Texture2D> &p_tex) { void TextureRect::set_texture(const Ref<Texture2D> &p_tex) {