asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #78772 from MineBill/master

Browse source 
Fix VoxelGI saving VoxelGIData as a built-in file, despite being prompted to save it to an external file
This commit is contained in:
Yuri Sizov 2023-07-12 17:16:29 +02:00
commit 4d862d6cc9
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
editor/plugins/voxel_gi_editor_plugin.cpp
View file

@ -166,8 +166,13 @@ void VoxelGIEditorPlugin::_voxel_gi_save_path_and_bake(const String &p_path) {
probe_file->hide();
if (voxel_gi) {
voxel_gi->bake();
ERR_FAIL_COND(voxel_gi->get_probe_data().is_null());
ResourceSaver::save(voxel_gi->get_probe_data(), p_path, ResourceSaver::FLAG_CHANGE_PATH);
// Ensure the VoxelGIData is always saved to an external resource.
// This avoids bloating the scene file with large binary data,
// which would be serialized as Base64 if the scene is a `.tscn` file.
Ref<VoxelGIData> voxel_gi_data = voxel_gi->get_probe_data();
ERR_FAIL_COND(voxel_gi_data.is_null());
voxel_gi_data->set_path(p_path);
ResourceSaver::save(voxel_gi_data, p_path, ResourceSaver::FLAG_CHANGE_PATH);
}
}