asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Swap rest pose actions in the Skeleton2D editor

Browse source 
The texts were changed before, but the actions weren't swapped around.
This led to unexpected behavior.
This commit is contained in:
Hugo Locurcio 2021-11-10 21:08:56 +01:00
parent 3668312e78
commit 4ff1431993
No known key found for this signature in database
GPG key ID: 39E8F8BE30B0A49C
2 changed files with 19 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
editor/plugins/skeleton_2d_editor_plugin.cpp
View file

@ -52,22 +52,6 @@ void Skeleton2DEditor::_menu_option(int p_option) {
} }
switch (p_option) { switch (p_option) {
case MENU_OPTION_MAKE_REST: {
if (node->get_bone_count() == 0) {
err_dialog->set_text(TTR("This skeleton has no bones, create some children Bone2D nodes."));
err_dialog->popup_centered();
return;
}
UndoRedo *ur = EditorNode::get_singleton()->get_undo_redo();
ur->create_action(TTR("Create Rest Pose from Bones"));
for (int i = 0; i < node->get_bone_count(); i++) {
Bone2D *bone = node->get_bone(i);
ur->add_do_method(bone, "set_rest", bone->get_transform());
ur->add_undo_method(bone, "set_rest", bone->get_rest());
}
ur->commit_action();
} break;
case MENU_OPTION_SET_REST: { case MENU_OPTION_SET_REST: {
if (node->get_bone_count() == 0) { if (node->get_bone_count() == 0) {
err_dialog->set_text(TTR("This skeleton has no bones, create some children Bone2D nodes.")); err_dialog->set_text(TTR("This skeleton has no bones, create some children Bone2D nodes."));
@ -84,6 +68,22 @@ void Skeleton2DEditor::_menu_option(int p_option) {
ur->commit_action(); ur->commit_action();
} break; } break;
case MENU_OPTION_MAKE_REST: {
if (node->get_bone_count() == 0) {
err_dialog->set_text(TTR("This skeleton has no bones, create some children Bone2D nodes."));
err_dialog->popup_centered();
return;
}
UndoRedo *ur = EditorNode::get_singleton()->get_undo_redo();
ur->create_action(TTR("Create Rest Pose from Bones"));
for (int i = 0; i < node->get_bone_count(); i++) {
Bone2D *bone = node->get_bone(i);
ur->add_do_method(bone, "set_rest", bone->get_transform());
ur->add_undo_method(bone, "set_rest", bone->get_rest());
}
ur->commit_action();
} break;
} }
} }
@ -98,10 +98,10 @@ Skeleton2DEditor::Skeleton2DEditor() {
options->set_text(TTR("Skeleton2D")); options->set_text(TTR("Skeleton2D"));
options->set_icon(EditorNode::get_singleton()->get_gui_base()->get_theme_icon(SNAME("Skeleton2D"), SNAME("EditorIcons"))); options->set_icon(EditorNode::get_singleton()->get_gui_base()->get_theme_icon(SNAME("Skeleton2D"), SNAME("EditorIcons")));
options->get_popup()->add_item(TTR("Reset to Rest Pose"), MENU_OPTION_MAKE_REST); options->get_popup()->add_item(TTR("Reset to Rest Pose"), MENU_OPTION_SET_REST);
options->get_popup()->add_separator(); options->get_popup()->add_separator();
// Use the "Overwrite" word to highlight that this is a destructive operation. // Use the "Overwrite" word to highlight that this is a destructive operation.
options->get_popup()->add_item(TTR("Overwrite Rest Pose"), MENU_OPTION_SET_REST); options->get_popup()->add_item(TTR("Overwrite Rest Pose"), MENU_OPTION_MAKE_REST);
options->set_switch_on_hover(true); options->set_switch_on_hover(true);
options->get_popup()->connect("id_pressed", callable_mp(this, &Skeleton2DEditor::_menu_option)); options->get_popup()->connect("id_pressed", callable_mp(this, &Skeleton2DEditor::_menu_option));

2
editor/plugins/skeleton_2d_editor_plugin.h
View file

@ -40,8 +40,8 @@ class Skeleton2DEditor : public Control {
GDCLASS(Skeleton2DEditor, Control); GDCLASS(Skeleton2DEditor, Control);
enum Menu { enum Menu {
MENU_OPTION_MAKE_REST,
MENU_OPTION_SET_REST, MENU_OPTION_SET_REST,
MENU_OPTION_MAKE_REST,
}; };
Skeleton2D *node; Skeleton2D *node;