From 1a559c9889b5a8ae9fdc65482548c6bad0b61eb4 Mon Sep 17 00:00:00 2001 From: Marcel Admiraal Date: Mon, 29 Jun 2020 16:40:25 +0100 Subject: [PATCH 1/2] Create degenerate triangles when inserting an edge into a CSG face. They will be deleted when the faces are merged, but their edges are needed for merging faces. --- modules/csg/csg.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/modules/csg/csg.cpp b/modules/csg/csg.cpp index d0c9bf5d38e..a3250f0d579 100644 --- a/modules/csg/csg.cpp +++ b/modules/csg/csg.cpp @@ -1068,15 +1068,6 @@ void CSGBrushOperation::Build2DFaces::_find_edge_intersections(const Vector2 p_s break; } - // Don't create degenerate triangles. - Vector2 split_edge1[2] = { vertices[new_vertex_idx].point, edge_points[0] }; - Vector2 split_edge2[2] = { vertices[new_vertex_idx].point, edge_points[1] }; - Vector2 new_edge[2] = { vertices[new_vertex_idx].point, vertices[opposite_vertex_idx].point }; - if (are_segements_parallel(split_edge1, new_edge, vertex_snap2) && - are_segements_parallel(split_edge2, new_edge, vertex_snap2)) { - break; - } - // If opposite point is on the segemnt, add its index to segment indices too. Vector2 closest_point = Geometry2D::get_closest_point_to_segment(vertices[opposite_vertex_idx].point, p_segment_points); if ((closest_point - vertices[opposite_vertex_idx].point).length_squared() < vertex_snap2) { From 63f4e9219585200c380189b765bff01dd79214c1 Mon Sep 17 00:00:00 2001 From: Marcel Admiraal Date: Mon, 29 Jun 2020 17:52:36 +0100 Subject: [PATCH 2/2] Use is_equal_approx() instead of vertex_snap when checking if ray is colliding with equiplanar CSG faces. --- modules/csg/csg.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/csg/csg.cpp b/modules/csg/csg.cpp index a3250f0d579..6c0a3a4ca38 100644 --- a/modules/csg/csg.cpp +++ b/modules/csg/csg.cpp @@ -523,7 +523,7 @@ void CSGBrushOperation::MeshMerge::_add_distance(List &r_intersectionsA, // Check if distance exists. for (const List::Element *E = intersections.front(); E; E = E->next()) { - if (Math::abs(**E - p_distance) < vertex_snap) { + if (Math::is_equal_approx(**E, p_distance)) { return; } }