asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UWP: Keep upstream names for capabilities preset settings to avoid mismatch

Browse source 
The previous code used `camelcase_to_underscore` to prettify the names for
display in the export preset, but it leads to inconsistencies if we don't make
sure to do the reverse operation when writing to the `AppxManifest.xml`.

It's simpler to keep the same names as in the manifest, which is also what
users will see referenced in MS documentation.

Fixes #47900.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
(cherry picked from commit c87e49d7bc)
This commit is contained in:
Gromph 2021-04-14 18:01:08 -07:00 committed by Rémi Verschelde
parent 898d404f66
commit 565d205d91
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
platform/uwp/export/export.cpp
View file

@ -1056,19 +1056,19 @@ public:
// Capabilities // Capabilities
const char **basic = uwp_capabilities; const char **basic = uwp_capabilities;
while (*basic) { while (*basic) {
r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "capabilities/" + String(*basic).camelcase_to_underscore(false)), false)); r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "capabilities/" + String(*basic)), false));
basic++; basic++;
} }
const char **uap = uwp_uap_capabilities; const char **uap = uwp_uap_capabilities;
while (*uap) { while (*uap) {
r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "capabilities/" + String(*uap).camelcase_to_underscore(false)), false)); r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "capabilities/" + String(*uap)), false));
uap++; uap++;
} }
const char **device = uwp_device_capabilities; const char **device = uwp_device_capabilities;
while (*device) { while (*device) {
r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "capabilities/" + String(*device).camelcase_to_underscore(false)), false)); r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "capabilities/" + String(*device)), false));
device++; device++;
} }
} }