asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

GDScript: Allow usage of literal false in assert without a warning

Browse source
This commit is contained in:
Dmitrii Maganov 2023-03-17 05:36:50 +02:00
parent 1e0f7a12f7
commit 5d0b183822
3 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/gdscript/gdscript_analyzer.cpp
View file

@ -2007,7 +2007,7 @@ void GDScriptAnalyzer::resolve_assert(GDScriptParser::AssertNode *p_assert) {
if (p_assert->condition->is_constant) {
if (p_assert->condition->reduced_value.booleanize()) {
parser->push_warning(p_assert->condition, GDScriptWarning::ASSERT_ALWAYS_TRUE);
} else {
} else if (!(p_assert->condition->type == GDScriptParser::Node::LITERAL && static_cast<GDScriptParser::LiteralNode *>(p_assert->condition)->value.get_type() == Variant::BOOL)) {
parser->push_warning(p_assert->condition, GDScriptWarning::ASSERT_ALWAYS_FALSE);
}
}

6
modules/gdscript/tests/scripts/analyzer/features/assert_literal_false.gd Normal file
View file

@ -0,0 +1,6 @@
func test():
var never: Variant = false
if never:
assert(false)
assert(false, 'message')
print('ok')

2
modules/gdscript/tests/scripts/analyzer/features/assert_literal_false.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_OK
ok