asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #76833 from kleonc/gridcontainer-max-row-column-calculations-fix

Browse source 
[3.x] Fix `GridContainer` max row/column calculations not skipping hidden children
This commit is contained in:
Rémi Verschelde 2023-05-08 15:06:28 +02:00 committed by GitHub
commit 627a2909c2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
scene/gui/grid_container.cpp
View file

@ -40,8 +40,6 @@ void GridContainer::_notification(int p_what) {
int hsep = get_constant("hseparation");
int vsep = get_constant("vseparation");
int max_col = MIN(get_child_count(), columns);
int max_row = ceil((float)get_child_count() / (float)columns);
// Compute the per-column/per-row data.
int valid_controls_index = 0;
@ -78,6 +76,9 @@ void GridContainer::_notification(int p_what) {
}
}
int max_col = MIN(valid_controls_index, columns);
int max_row = ceil((float)valid_controls_index / (float)columns);
// Consider all empty columns expanded.
for (int i = valid_controls_index; i < columns; i++) {
col_expanded.insert(i);