asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #89577 from lawnjelly/fti2d_fix_light_resets

Browse source 
[3.x] Physics Interpolation 2D - fix light and light occluder resetting
This commit is contained in:
lawnjelly 2024-03-16 17:13:02 +00:00 committed by GitHub
commit 64457bab85
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
scene/2d/light_2d.cpp
View file

@ -319,7 +319,12 @@ void Light2D::_notification(int p_what) {
} break;
case NOTIFICATION_RESET_PHYSICS_INTERPOLATION: {
if (is_visible_in_tree() && is_physics_interpolated()) {
VisualServer::get_singleton()->canvas_light_reset_physics_interpolation(canvas_light);
// Explicitly make sure the transform is up to date in VisualServer before
// resetting. This is necessary because NOTIFICATION_TRANSFORM_CHANGED
// is normally deferred, and a client change to transform will not always be sent
// before the reset, so we need to guarantee this.
VS::get_singleton()->canvas_light_set_transform(canvas_light, get_global_transform());
VS::get_singleton()->canvas_light_reset_physics_interpolation(canvas_light);
}
} break;
}

7
scene/2d/light_occluder_2d.cpp
View file

@ -202,7 +202,12 @@ void LightOccluder2D::_notification(int p_what) {
} break;
case NOTIFICATION_RESET_PHYSICS_INTERPOLATION: {
if (is_visible_in_tree() && is_physics_interpolated()) {
VisualServer::get_singleton()->canvas_light_occluder_reset_physics_interpolation(occluder);
// Explicitly make sure the transform is up to date in VisualServer before
// resetting. This is necessary because NOTIFICATION_TRANSFORM_CHANGED
// is normally deferred, and a client change to transform will not always be sent
// before the reset, so we need to guarantee this.
VS::get_singleton()->canvas_light_occluder_set_transform(occluder, get_global_transform());
VS::get_singleton()->canvas_light_occluder_reset_physics_interpolation(occluder);
}
} break;
}