asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix out of bounds array access on OS_X11 code

Browse source 
The problem happened on methods `get_screen_position`, `get_screen_size`
and `set_current_screen` when they were passed a negative screen value.

Fixes:
- #46184
- #46185
- #46186
This commit is contained in:
Pedro Rodrigues 2021-02-28 17:11:25 +00:00
parent 8385a0d8ad
commit 66da113237
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
platform/x11/os_x11.cpp
View file

@ -1171,8 +1171,12 @@ int OS_X11::get_current_screen() const {
}
void OS_X11::set_current_screen(int p_screen) {
int count = get_screen_count();
if (p_screen >= count) return;
if (p_screen == -1) {
p_screen = get_current_screen();
}
// Check if screen is valid
ERR_FAIL_INDEX(p_screen, get_screen_count());
if (current_videomode.fullscreen) {
Point2i position = get_screen_position(p_screen);
@ -1201,9 +1205,9 @@ Point2 OS_X11::get_screen_position(int p_screen) const {
int count;
XineramaScreenInfo *xsi = XineramaQueryScreens(x11_display, &count);
if (p_screen >= count) {
return Point2i(0, 0);
}
// Check if screen is valid
ERR_FAIL_INDEX_V(p_screen, count, Point2i(0, 0));
Point2i position = Point2i(xsi[p_screen].x_org, xsi[p_screen].y_org);
@ -1224,7 +1228,9 @@ Size2 OS_X11::get_screen_size(int p_screen) const {
int count;
XineramaScreenInfo *xsi = XineramaQueryScreens(x11_display, &count);
if (p_screen >= count) return Size2i(0, 0);
// Check if screen is valid
ERR_FAIL_INDEX_V(p_screen, count, Size2i(0, 0));
Size2i size = Point2i(xsi[p_screen].width, xsi[p_screen].height);
XFree(xsi);