From 68b5f101c7274d9e57dde4f779e71d927e6664b2 Mon Sep 17 00:00:00 2001 From: Bojidar Marinov Date: Sun, 28 Jul 2019 17:00:05 +0300 Subject: [PATCH] Make it so that 2D viewport does not pan while editing tilemaps Fixes #30875 --- editor/plugins/canvas_item_editor_plugin.cpp | 10 +++++----- editor/plugins/canvas_item_editor_plugin.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/editor/plugins/canvas_item_editor_plugin.cpp b/editor/plugins/canvas_item_editor_plugin.cpp index 19199f37efc..92dc3e7f0d7 100644 --- a/editor/plugins/canvas_item_editor_plugin.cpp +++ b/editor/plugins/canvas_item_editor_plugin.cpp @@ -1058,9 +1058,9 @@ bool CanvasItemEditor::_gui_input_rulers_and_guides(const Ref &p_eve return false; } -bool CanvasItemEditor::_gui_input_zoom_or_pan(const Ref &p_event) { +bool CanvasItemEditor::_gui_input_zoom_or_pan(const Ref &p_event, bool p_already_accepted) { Ref b = p_event; - if (b.is_valid()) { + if (b.is_valid() && !p_already_accepted) { bool pan_on_scroll = bool(EditorSettings::get_singleton()->get("editors/2d/scroll_to_pan")) && !b->get_control(); if (b->is_pressed() && b->get_button_index() == BUTTON_WHEEL_DOWN) { @@ -1162,14 +1162,14 @@ bool CanvasItemEditor::_gui_input_zoom_or_pan(const Ref &p_event) { } Ref magnify_gesture = p_event; - if (magnify_gesture.is_valid()) { + if (magnify_gesture.is_valid() && !p_already_accepted) { // Zoom gesture _zoom_on_position(zoom * magnify_gesture->get_factor(), magnify_gesture->get_position()); return true; } Ref pan_gesture = p_event; - if (pan_gesture.is_valid()) { + if (pan_gesture.is_valid() && !p_already_accepted) { // Pan gesture const Vector2 delta = (int(EditorSettings::get_singleton()->get("editors/2d/pan_speed")) / zoom) * pan_gesture->get_delta(); view_offset.x += delta.x; @@ -2268,7 +2268,7 @@ void CanvasItemEditor::_gui_input_viewport(const Ref &p_event) { } } - accepted = (_gui_input_zoom_or_pan(p_event) || accepted); + accepted = (_gui_input_zoom_or_pan(p_event, accepted) || accepted); if (accepted) accept_event(); diff --git a/editor/plugins/canvas_item_editor_plugin.h b/editor/plugins/canvas_item_editor_plugin.h index 2a85b20424a..553ded6b141 100644 --- a/editor/plugins/canvas_item_editor_plugin.h +++ b/editor/plugins/canvas_item_editor_plugin.h @@ -466,7 +466,7 @@ private: bool _gui_input_resize(const Ref &p_event); bool _gui_input_rotate(const Ref &p_event); bool _gui_input_select(const Ref &p_event); - bool _gui_input_zoom_or_pan(const Ref &p_event); + bool _gui_input_zoom_or_pan(const Ref &p_event, bool p_already_accepted); bool _gui_input_rulers_and_guides(const Ref &p_event); bool _gui_input_hover(const Ref &p_event);