asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #46336 from m4gr3d/fix_android_resources_inclusion

Browse source 
[3.2] Update the filtering logic to properly handle directories with `.gdignore` files
This commit is contained in:
Rémi Verschelde 2021-02-25 14:15:19 +01:00 committed by GitHub
commit 693a27e9dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
editor/editor_export.cpp
View file

@ -471,6 +471,10 @@ void EditorExportPlatform::_edit_files_with_filter(DirAccess *da, const Vector<S
String dir = dirs[i];
if (dir.begins_with("."))
continue;
if (EditorFileSystem::_should_skip_directory(cur_dir + dir))
continue;
da->change_dir(dir);
_edit_files_with_filter(da, p_filters, r_list, exclude);
da->change_dir("..");

18
editor/editor_file_system.cpp
View file

@ -684,9 +684,7 @@ void EditorFileSystem::_scan_new_dir(EditorFileSystemDirectory *p_dir, DirAccess
if (f.begins_with(".")) // Ignore special and . / ..
continue;
if (FileAccess::exists(cd.plus_file(f).plus_file("project.godot"))) // skip if another project inside this
continue;
if (FileAccess::exists(cd.plus_file(f).plus_file(".gdignore"))) // skip if another project inside this
if (_should_skip_directory(cd.plus_file(f)))
continue;
dirs.push_back(f);
@ -886,9 +884,7 @@ void EditorFileSystem::_scan_fs_changes(EditorFileSystemDirectory *p_dir, const
int idx = p_dir->find_dir_index(f);
if (idx == -1) {
if (FileAccess::exists(cd.plus_file(f).plus_file("project.godot"))) // skip if another project inside this
continue;
if (FileAccess::exists(cd.plus_file(f).plus_file(".gdignore"))) // skip if another project inside this
if (_should_skip_directory(cd.plus_file(f)))
continue;
EditorFileSystemDirectory *efd = memnew(EditorFileSystemDirectory);
@ -2024,6 +2020,16 @@ Error EditorFileSystem::_resource_import(const String &p_path) {
return OK;
}
bool EditorFileSystem::_should_skip_directory(const String &p_path) {
if (FileAccess::exists(p_path.plus_file("project.godot"))) // skip if another project inside this
return true;
if (FileAccess::exists(p_path.plus_file(".gdignore"))) // skip if a `.gdignore` file is inside this
return true;
return false;
}
bool EditorFileSystem::is_group_file(const String &p_path) const {
return group_file_cache.has(p_path);
}

2
editor/editor_file_system.h
View file

@ -275,6 +275,8 @@ public:
bool is_group_file(const String &p_path) const;
void move_group_file(const String &p_path, const String &p_new_path);
static bool _should_skip_directory(const String &p_path);
EditorFileSystem();
~EditorFileSystem();
};

3
platform/android/export/export.cpp
View file

@ -2774,6 +2774,9 @@ public:
print_verbose("- custom build enabled: " + bool_to_string(use_custom_build));
print_verbose("- apk expansion enabled: " + bool_to_string(apk_expansion));
print_verbose("- enabled abis: " + String(",").join(enabled_abis));
print_verbose("- export filter: " + itos(p_preset->get_export_filter()));
print_verbose("- include filter: " + p_preset->get_include_filter());
print_verbose("- exclude filter: " + p_preset->get_exclude_filter());
Ref<Image> splash_image;
Ref<Image> splash_bg_color_image;