asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #67192 from RedMser/light-scale-warning

Browse source 
Show warning when scaling Light3D nodes
This commit is contained in:
Rémi Verschelde 2022-10-11 09:26:56 +02:00
commit 6b8772dbb2
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
scene/3d/light_3d.cpp
View file

@ -165,6 +165,16 @@ AABB Light3D::get_aabb() const {
return AABB(); return AABB();
} }
PackedStringArray Light3D::get_configuration_warnings() const {
PackedStringArray warnings = VisualInstance3D::get_configuration_warnings();
if (!get_scale().is_equal_approx(Vector3(1, 1, 1))) {
warnings.push_back(RTR("A light's scale does not affect the visual size of the light."));
}
return warnings;
}
void Light3D::set_bake_mode(BakeMode p_mode) { void Light3D::set_bake_mode(BakeMode p_mode) {
bake_mode = p_mode; bake_mode = p_mode;
RS::get_singleton()->light_set_bake_mode(light, RS::LightBakeMode(p_mode)); RS::get_singleton()->light_set_bake_mode(light, RS::LightBakeMode(p_mode));
@ -579,7 +589,7 @@ OmniLight3D::ShadowMode OmniLight3D::get_shadow_mode() const {
} }
PackedStringArray OmniLight3D::get_configuration_warnings() const { PackedStringArray OmniLight3D::get_configuration_warnings() const {
PackedStringArray warnings = Node::get_configuration_warnings(); PackedStringArray warnings = Light3D::get_configuration_warnings();
if (!has_shadow() && get_projector().is_valid()) { if (!has_shadow() && get_projector().is_valid()) {
warnings.push_back(RTR("Projector texture only works with shadows active.")); warnings.push_back(RTR("Projector texture only works with shadows active."));
@ -609,7 +619,7 @@ OmniLight3D::OmniLight3D() :
} }
PackedStringArray SpotLight3D::get_configuration_warnings() const { PackedStringArray SpotLight3D::get_configuration_warnings() const {
PackedStringArray warnings = Node::get_configuration_warnings(); PackedStringArray warnings = Light3D::get_configuration_warnings();
if (has_shadow() && get_param(PARAM_SPOT_ANGLE) >= 90.0) { if (has_shadow() && get_param(PARAM_SPOT_ANGLE) >= 90.0) {
warnings.push_back(RTR("A SpotLight3D with an angle wider than 90 degrees cannot cast shadows.")); warnings.push_back(RTR("A SpotLight3D with an angle wider than 90 degrees cannot cast shadows."));

1
scene/3d/light_3d.h
View file

@ -147,6 +147,7 @@ public:
Color get_correlated_color() const; Color get_correlated_color() const;
virtual AABB get_aabb() const override; virtual AABB get_aabb() const override;
virtual PackedStringArray get_configuration_warnings() const override;
Light3D(); Light3D();
~Light3D(); ~Light3D();