From 6e865d1e11be5f2e289b85c0f1392d868f8478fe Mon Sep 17 00:00:00 2001 From: Paul Trojahn Date: Sat, 2 Mar 2019 13:33:54 +0100 Subject: [PATCH] Fix preview in file dialog If the preview is already cached, queue_ressource_preview calls _thumbnail_done immediately, so preview_waiting is never set to false again. The progress wheel isn't rendered, because the WaitPreview icons don't exist. This should probably be Progress. Fixes #25749 --- editor/editor_file_dialog.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/editor/editor_file_dialog.cpp b/editor/editor_file_dialog.cpp index 765a330aafc..cdc06503e94 100644 --- a/editor/editor_file_dialog.cpp +++ b/editor/editor_file_dialog.cpp @@ -75,7 +75,7 @@ void EditorFileDialog::_notification(int p_what) { preview_wheel_index++; if (preview_wheel_index >= 8) preview_wheel_index = 0; - Ref frame = get_icon("WaitPreview" + itos(preview_wheel_index + 1), "EditorIcons"); + Ref frame = get_icon("Progress" + itos(preview_wheel_index + 1), "EditorIcons"); preview->set_texture(frame); preview_wheel_timeout = 0.1; } @@ -323,11 +323,10 @@ void EditorFileDialog::_request_single_thumbnail(const String &p_path) { if (!FileAccess::exists(p_path)) return; - EditorResourcePreview::get_singleton()->queue_resource_preview(p_path, this, "_thumbnail_done", p_path); - set_process(true); preview_waiting = true; preview_wheel_timeout = 0; + EditorResourcePreview::get_singleton()->queue_resource_preview(p_path, this, "_thumbnail_done", p_path); } void EditorFileDialog::_action_pressed() {