asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #56791 from timothyqiu/object-check

Browse source 
[3.x] Fix crash when `is` keyword is tested against a String variable
This commit is contained in:
Rémi Verschelde 2022-01-14 20:00:56 +01:00 committed by GitHub
commit 75cc95c8c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/gdscript/gdscript_function.cpp
View file

@ -473,7 +473,7 @@ Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_a
err_text = "Left operand of 'is' was already freed."; err_text = "Left operand of 'is' was already freed.";
OPCODE_BREAK; OPCODE_BREAK;
} }
if (b->is_invalid_object()) { if (b->get_type() != Variant::OBJECT || b->is_invalid_object()) {
err_text = "Right operand of 'is' is not a class."; err_text = "Right operand of 'is' is not a class.";
OPCODE_BREAK; OPCODE_BREAK;
} }