asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #51029 from lawnjelly/portals_gizmo_margins

Browse source 
Portals - fix gizmo margin scaling
This commit is contained in:
Rémi Verschelde 2021-07-29 22:13:45 +02:00 committed by GitHub
commit 78d9a4ae7e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scene/3d/portal.cpp
View file

@ -167,6 +167,15 @@ void Portal::_notification(int p_what) {
case NOTIFICATION_TRANSFORM_CHANGED: { case NOTIFICATION_TRANSFORM_CHANGED: {
// keep the world points and the visual server up to date // keep the world points and the visual server up to date
portal_update(); portal_update();
// In theory we shouldn't need to update the gizmo when the transform
// changes .. HOWEVER, the portal margin is displayed in world space units,
// back transformed to model space.
// If the Z scale is changed by the user, the portal margin length can become incorrect
// and needs 'resyncing' to the global scale of the portal node.
// We really only need to do this when Z scale is changed, but it is easier codewise
// to always change it, unless we have evidence this is a performance problem.
update_gizmo();
} break; } break;
} }
} }