diff --git a/editor/code_editor.cpp b/editor/code_editor.cpp index 44cd15ab902..9a4513d18a5 100644 --- a/editor/code_editor.cpp +++ b/editor/code_editor.cpp @@ -1509,7 +1509,7 @@ void CodeTextEditor::_set_show_warnings_panel(bool p_show) { } void CodeTextEditor::_toggle_scripts_pressed() { - toggle_scripts_button->set_icon(ScriptEditor::get_singleton()->toggle_scripts_panel(this) ? get_icon("Back", "EditorIcons") : get_icon("Forward", "EditorIcons")); + toggle_scripts_button->set_icon(ScriptEditor::get_singleton()->toggle_scripts_panel() ? get_icon("Back", "EditorIcons") : get_icon("Forward", "EditorIcons")); } void CodeTextEditor::_error_pressed(const Ref &p_event) { diff --git a/editor/plugins/script_editor_plugin.cpp b/editor/plugins/script_editor_plugin.cpp index 54b9cf06301..3d814878a3c 100644 --- a/editor/plugins/script_editor_plugin.cpp +++ b/editor/plugins/script_editor_plugin.cpp @@ -987,11 +987,8 @@ Array ScriptEditor::_get_open_scripts() const { return ret; } -bool ScriptEditor::toggle_scripts_panel(CodeTextEditor *p_editor) { +bool ScriptEditor::toggle_scripts_panel() { list_split->set_visible(!list_split->is_visible()); - if (p_editor) { - p_editor->update_toggle_scripts_button(); - } return list_split->is_visible(); } @@ -1141,14 +1138,13 @@ void ScriptEditor::_menu_option(int p_option) { } break; case TOGGLE_SCRIPTS_PANEL: { if (current) { - CodeTextEditor *code_editor = NULL; - ScriptTextEditor *editor = dynamic_cast(current); + ScriptTextEditor *editor = Object::cast_to(current); + toggle_scripts_panel(); if (editor) { - code_editor = editor->code_editor; + editor->update_toggle_scripts_button(); } - toggle_scripts_panel(code_editor); } else { - toggle_scripts_panel(NULL); + toggle_scripts_panel(); } } } diff --git a/editor/plugins/script_editor_plugin.h b/editor/plugins/script_editor_plugin.h index e40d596be77..e2fd67676bf 100644 --- a/editor/plugins/script_editor_plugin.h +++ b/editor/plugins/script_editor_plugin.h @@ -419,7 +419,7 @@ protected: public: static ScriptEditor *get_singleton() { return script_editor; } - bool toggle_scripts_panel(CodeTextEditor *p_editor); + bool toggle_scripts_panel(); bool is_scripts_panel_toggled(); void ensure_focus_current(); void apply_scripts() const; diff --git a/editor/plugins/script_text_editor.cpp b/editor/plugins/script_text_editor.cpp index 9bda0f50e4c..ec1cda5287d 100644 --- a/editor/plugins/script_text_editor.cpp +++ b/editor/plugins/script_text_editor.cpp @@ -966,6 +966,12 @@ void ScriptTextEditor::_lookup_symbol(const String &p_symbol, int p_row, int p_c } } +void ScriptTextEditor::update_toggle_scripts_button() { + if (code_editor != NULL) { + code_editor->update_toggle_scripts_button(); + } +} + void ScriptTextEditor::_update_connected_methods() { TextEdit *text_edit = code_editor->get_text_edit(); text_edit->clear_info_icons(); diff --git a/editor/plugins/script_text_editor.h b/editor/plugins/script_text_editor.h index 82d365fcaaa..ac29e90c028 100644 --- a/editor/plugins/script_text_editor.h +++ b/editor/plugins/script_text_editor.h @@ -55,6 +55,7 @@ class ScriptTextEditor : public ScriptEditorBase { GDCLASS(ScriptTextEditor, ScriptEditorBase); + CodeTextEditor *code_editor; RichTextLabel *warnings_panel; Ref