asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions 1

Merge pull request #90787 from Chaosus/vs_fix_port_bug

Browse source 
Fix incorrect behavior at expanding an output port in visual shader node
This commit is contained in:
Rémi Verschelde 2024-04-17 20:26:31 +02:00
commit 8293aac75c
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
editor/plugins/visual_shader_editor_plugin.cpp
View file

@ -953,8 +953,8 @@ void VisualShaderGraphPlugin::add_node(VisualShader::Type p_type, int p_id, bool
bool port_left_used = false; bool port_left_used = false;
String name_left; String name_left;
if (valid_left) { if (valid_left) {
name_left = vsnode->get_input_port_name(i); name_left = vsnode->get_input_port_name(j);
port_left = vsnode->get_input_port_type(i); port_left = vsnode->get_input_port_type(j);
for (const VisualShader::Connection &E : connections) { for (const VisualShader::Connection &E : connections) {
if (E.to_node == p_id && E.to_port == j) { if (E.to_node == p_id && E.to_port == j) {
port_left_used = true; port_left_used = true;
@ -989,15 +989,15 @@ void VisualShaderGraphPlugin::add_node(VisualShader::Type p_type, int p_id, bool
Variant default_value; Variant default_value;
if (valid_left && !port_left_used) { if (valid_left && !port_left_used) {
default_value = vsnode->get_input_port_default_value(i); default_value = vsnode->get_input_port_default_value(j);
} }
Button *button = memnew(Button); Button *button = memnew(Button);
hb->add_child(button); hb->add_child(button);
register_default_input_button(p_id, i, button); register_default_input_button(p_id, j, button);
button->connect("pressed", callable_mp(editor, &VisualShaderEditor::_edit_port_default_input).bind(button, p_id, i)); button->connect("pressed", callable_mp(editor, &VisualShaderEditor::_edit_port_default_input).bind(button, p_id, j));
if (default_value.get_type() != Variant::NIL) { // only a label if (default_value.get_type() != Variant::NIL) { // only a label
set_input_port_default_value(p_type, p_id, i, default_value); set_input_port_default_value(p_type, p_id, j, default_value);
} else { } else {
button->hide(); button->hide();
} }