asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix uniforms with the same name shadowing others

Browse source 
Follow-up of #7344
This commit is contained in:
Pedro J. Estébanez 2017-01-10 17:05:09 +01:00
parent 40de567297
commit 8589a1b117
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/gles2/shader_compiler_gles2.cpp
View file

@ -571,15 +571,12 @@ Error ShaderCompilerGLES2::compile_node(SL::ProgramNode *p_program) {
global_code+=uline;
if (uniforms) {
//if (uniforms->has(E->key())) {
// //repeated uniform, error
// ERR_EXPLAIN("Uniform already exists from other shader: "+String(E->key()));
// ERR_FAIL_COND_V(uniforms->has(E->key()),ERR_ALREADY_EXISTS);
//
// }
SL::Uniform u = E->get();
u.order+=ubase;
uniforms->insert(E->key(),u);
// Check to avoid uniforms with the same name being re-added to avoid overwriting entries
if (!uniforms->has(E->key())) {
SL::Uniform u = E->get();
u.order+=ubase;
uniforms->insert(E->key(),u);
}
}
}