asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #58882 from V-Sekai/avoid-gizmo-crashes

Browse source 
Avoid gizmo crashes in cases where the points are null
This commit is contained in:
Rémi Verschelde 2022-03-08 07:49:34 +01:00 committed by GitHub
commit 86b0faf2ec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
editor/plugins/skeleton_3d_editor_plugin.cpp
View file

@ -528,19 +528,21 @@ void Skeleton3DEditor::move_skeleton_bone(NodePath p_skeleton_path, int32_t p_se
void Skeleton3DEditor::_joint_tree_selection_changed() {
TreeItem *selected = joint_tree->get_selected();
if (selected) {
const String path = selected->get_metadata(0);
if (path.begins_with("bones/")) {
const int b_idx = path.get_slicec('/', 1).to_int();
const String bone_path = "bones/" + itos(b_idx) + "/";
pose_editor->set_target(bone_path);
pose_editor->set_keyable(keyable);
selected_bone = b_idx;
}
if (!selected) {
return;
}
const String path = selected->get_metadata(0);
if (!path.begins_with("bones/")) {
return;
}
const int b_idx = path.get_slicec('/', 1).to_int();
selected_bone = b_idx;
if (pose_editor) {
const String bone_path = "bones/" + itos(b_idx) + "/";
pose_editor->set_target(bone_path);
pose_editor->set_keyable(keyable);
pose_editor->set_visible(selected);
}
pose_editor->set_visible(selected);
set_bone_options_enabled(selected);
_update_properties();
_update_gizmo_visible();