asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix 'unreachable-code' false-positive, fixes #55154

Browse source
This commit is contained in:
Pawel Lampe 2021-11-21 15:53:21 +01:00
parent ed02b8af59
commit 86c0e38e8f
3 changed files with 19 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/gdscript/gdscript_parser.cpp
View file

@ -1813,7 +1813,6 @@ GDScriptParser::MatchNode *GDScriptParser::parse_match() {
#ifdef DEBUG_ENABLED
bool all_have_return = true;
bool have_wildcard = false;
bool wildcard_has_return = false;
bool have_wildcard_without_continue = false;
#endif
@ -1831,9 +1830,6 @@ GDScriptParser::MatchNode *GDScriptParser::parse_match() {
if (branch->has_wildcard) {
have_wildcard = true;
if (branch->block->has_return) {
wildcard_has_return = true;
}
if (!branch->block->has_continue) {
have_wildcard_without_continue = true;
}
@ -1848,7 +1844,7 @@ GDScriptParser::MatchNode *GDScriptParser::parse_match() {
consume(GDScriptTokenizer::Token::DEDENT, R"(Expected an indented block after "match" statement.)");
#ifdef DEBUG_ENABLED
if (wildcard_has_return || (all_have_return && have_wildcard)) {
if (all_have_return && have_wildcard) {
current_suite->has_return = true;
}
#endif

16
modules/gdscript/tests/scripts/parser/warnings/unreachable_code_after_return_bug_55154.gd Normal file
View file

@ -0,0 +1,16 @@
func test():
var foo := "bar"
match foo:
"baz":
return
_:
pass
match foo:
"baz":
return
match foo:
"bar":
pass
_:
return
print("reached")

2
modules/gdscript/tests/scripts/parser/warnings/unreachable_code_after_return_bug_55154.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_OK
reached