asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #38480 from ThakeeNathees/tween-get-set-fix

Browse source 
Fix: Tween always return true for _get(), _set()
This commit is contained in:
Rémi Verschelde 2020-05-05 16:43:54 +02:00 committed by GitHub
commit 88e242116a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
scene/animation/tween.cpp
View file

@ -126,14 +126,17 @@ bool Tween::_set(const StringName &p_name, const Variant &p_value) {
String name = p_name;
if (name == "playback/speed" || name == "speed") { // Backwards compatibility
set_speed_scale(p_value);
return true;
} else if (name == "playback/active") {
set_active(p_value);
return true;
} else if (name == "playback/repeat") {
set_repeat(p_value);
return true;
}
return true;
return false;
}
bool Tween::_get(const StringName &p_name, Variant &r_ret) const {
@ -142,14 +145,17 @@ bool Tween::_get(const StringName &p_name, Variant &r_ret) const {
String name = p_name;
if (name == "playback/speed") { // Backwards compatibility
r_ret = speed_scale;
return true;
} else if (name == "playback/active") {
r_ret = is_active();
return true;
} else if (name == "playback/repeat") {
r_ret = is_repeat();
return true;
}
return true;
return false;
}
void Tween::_get_property_list(List<PropertyInfo> *p_list) const {