From 95cc19d320173336536088557207f1b6b010bdac Mon Sep 17 00:00:00 2001 From: Andy Maloney Date: Thu, 21 Jan 2021 16:07:25 -0500 Subject: [PATCH] Fix sign comparison error in lightmap_raycaster.cpp Compiling with latest clang on macOS produces this error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] This file is not present in 4.0/master. --- modules/raycast/lightmap_raycaster.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/raycast/lightmap_raycaster.cpp b/modules/raycast/lightmap_raycaster.cpp index 2a0a216f769..a8d7ce01869 100644 --- a/modules/raycast/lightmap_raycaster.cpp +++ b/modules/raycast/lightmap_raycaster.cpp @@ -144,7 +144,7 @@ void LightmapRaycasterEmbree::add_mesh(const Vector &p_vertices, const embree_normals = (Vec3fa *)rtcSetNewGeometryBuffer(embree_mesh, RTC_BUFFER_TYPE_VERTEX_ATTRIBUTE, 1, RTC_FORMAT_FLOAT3, sizeof(Vec3fa), vertex_count); } - for (uint32_t i = 0; i < vertex_count; i++) { + for (int i = 0; i < vertex_count; i++) { embree_vertices[i] = Vec3fa(p_vertices[i].x, p_vertices[i].y, p_vertices[i].z); embree_light_uvs[i] = Vec2fa(p_uv2s[i].x, p_uv2s[i].y); if (embree_normals != nullptr) {