asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Clarify EditorImportPlugin.get_visible_name.

Browse source 
According to the docs at
https://docs.godotengine.org/en/stable/tutorials/plugins/editor/import_plugins.html#the-editorimportplugin-class

> The get_visible_name() method is responsible for returning the name of
> the type it imports and it will be shown to the user in the Import dock.
> You should choose this name as a continuation to "Import as", e.g.
> "Import as Silly Material"

I've verified Godot's behavior reflects this, so the code examples
should reflect this.

Also document propagating save error in EditorImportPlugin.

It seems that the suggested code ignores any error from
`ResourceSaver.save`, but I think we should return it.
This commit is contained in:
Ryan Roden-Corrent 2021-02-09 08:30:27 -05:00
parent d39f6386ce
commit 9676650f2f
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
doc/classes/EditorImportPlugin.xml
View file

@ -16,7 +16,7 @@
return "my.special.plugin"
func get_visible_name():
return "Special Mesh Importer"
return "Special Mesh"
func get_recognized_extensions():
return ["special", "spec"]
@ -44,8 +44,7 @@
# Fill the Mesh with data read in "file", left as an exercise to the reader.
var filename = save_path + "." + get_save_extension()
ResourceSaver.save(filename, mesh)
return OK
return ResourceSaver.save(filename, mesh)
[/gdscript]
[csharp]
using Godot;
@ -60,7 +59,7 @@
public override String GetVisibleName()
{
return "Special Mesh Importer";
return "Special Mesh";
}
public override Godot.Collections.Array GetRecognizedExtensions()
@ -104,8 +103,7 @@
var mesh = new ArrayMesh();
// Fill the Mesh with data read in "file", left as an exercise to the reader.
String filename = savePath + "." + GetSaveExtension();
ResourceSaver.Save(filename, mesh);
return (int)Error.Ok;
return (int)ResourceSaver.Save(filename, mesh);
}
}
[/csharp]
@ -220,7 +218,7 @@
<return type="String">
</return>
<description>
Gets the name to display in the import window.
Gets the name to display in the import window. You should choose this name as a continuation to "Import as", e.g. "Import as Special Mesh".
</description>
</method>
<method name="import" qualifiers="virtual">