asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #33168 from nekomatata/weak-ref-leak

Browse source 
Fixed leak in gdscript when creating empty WeakRef
This commit is contained in:
Rémi Verschelde 2019-10-30 07:54:42 +01:00 committed by GitHub
commit 99324d9fda
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/gdscript/gdscript_functions.cpp
View file

@ -589,7 +589,8 @@ void GDScriptFunctions::call(Function p_func, const Variant **p_args, int p_arg_
r_ret = wref; r_ret = wref;
} }
} else if (p_args[0]->get_type() == Variant::NIL) { } else if (p_args[0]->get_type() == Variant::NIL) {
r_ret = memnew(WeakRef); Ref<WeakRef> wref = memnew(WeakRef);
r_ret = wref;
} else { } else {
r_error.error = Variant::CallError::CALL_ERROR_INVALID_ARGUMENT; r_error.error = Variant::CallError::CALL_ERROR_INVALID_ARGUMENT;
r_error.argument = 0; r_error.argument = 0;