asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #22983 from Ashafix/master

Browse source 
Better error message for malformed plugins
This commit is contained in:
Max Hilbrunner 2018-11-21 12:18:15 +01:00 committed by GitHub
commit 998d3a30a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
editor/editor_node.cpp
View file

@ -2568,6 +2568,12 @@ void EditorNode::set_addon_plugin_enabled(const String &p_addon, bool p_enabled)
return; return;
} }
//errors in the script cause the base_type to be ""
if (String(script->get_instance_base_type()) == "") {
show_warning(vformat(TTR("Unable to load addon script from path: '%s' There seems to be an error in the code, please check the syntax."), path));
return;
}
//could check inheritance.. //could check inheritance..
if (String(script->get_instance_base_type()) != "EditorPlugin") { if (String(script->get_instance_base_type()) != "EditorPlugin") {
show_warning(vformat(TTR("Unable to load addon script from path: '%s' Base type is not EditorPlugin."), path)); show_warning(vformat(TTR("Unable to load addon script from path: '%s' Base type is not EditorPlugin."), path));