asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix GLES directional shadow uninitialized data

Browse source 
Valgrind shows directional_shadow.fbo accessed when uninitialized in directional_shadow_create.
This commit is contained in:
lawnjelly 2022-09-06 08:08:28 +01:00
parent 4d4c6c187d
commit 9b294b298e
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/gles2/rasterizer_scene_gles2.h
View file

@ -288,13 +288,13 @@ public:
bool shadow_atlas_update_light(RID p_atlas, RID p_light_intance, float p_coverage, uint64_t p_light_version);
struct DirectionalShadow {
GLuint fbo;
GLuint depth;
GLuint color;
GLuint fbo = 0;
GLuint depth = 0;
GLuint color = 0;
int light_count;
int size;
int current_light;
int light_count = 0;
int size = 0;
int current_light = 0;
} directional_shadow;
virtual int get_directional_light_shadow_size(RID p_light_intance);

10
drivers/gles3/rasterizer_scene_gles3.h
View file

@ -278,11 +278,11 @@ public:
bool shadow_atlas_update_light(RID p_atlas, RID p_light_intance, float p_coverage, uint64_t p_light_version);
struct DirectionalShadow {
GLuint fbo;
GLuint depth;
int light_count;
int size;
int current_light;
GLuint fbo = 0;
GLuint depth = 0;
int light_count = 0;
int size = 0;
int current_light = 0;
} directional_shadow;
virtual int get_directional_light_shadow_size(RID p_light_intance);