asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #66257 from raulsntos/dotnet/suppress-CA1711

Browse source 
C#: Suppress EventHandler suffix diagnostic for signals
This commit is contained in:
Ignacio Roldán Etcheverry 2022-09-22 18:21:28 +02:00 • committed by GitHub
commit 9f028f6571
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 53 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/EventHandlerSuffixSuppressor.cs Normal file
View file

@ -0,0 +1,53 @@
using System.Collections.Immutable;
using System.Linq;
using System.Threading;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Diagnostics;
namespace Godot.SourceGenerators
{
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public class EventHandlerSuffixSuppressor : DiagnosticSuppressor
{
private static readonly SuppressionDescriptor _descriptor = new(
id: "GDSP0001",
suppressedDiagnosticId: "CA1711",
justification: "Signal delegates are used in events so the naming follows the guidelines.");
public override ImmutableArray<SuppressionDescriptor> SupportedSuppressions =>
ImmutableArray.Create(_descriptor);
public override void ReportSuppressions(SuppressionAnalysisContext context)
{
foreach (var diagnostic in context.ReportedDiagnostics)
{
AnalyzeDiagnostic(context, diagnostic, context.CancellationToken);
}
}
private static void AnalyzeDiagnostic(SuppressionAnalysisContext context, Diagnostic diagnostic, CancellationToken cancellationToken = default)
{
var location = diagnostic.Location;
var root = location.SourceTree?.GetRoot(cancellationToken);
var dds = root?
.FindNode(location.SourceSpan)
.DescendantNodesAndSelf()
.OfType<DelegateDeclarationSyntax>()
.FirstOrDefault();
if (dds == null)
return;
var semanticModel = context.GetSemanticModel(dds.SyntaxTree);
var delegateSymbol = semanticModel.GetDeclaredSymbol(dds, cancellationToken);
if (delegateSymbol == null)
return;
if (delegateSymbol.GetAttributes().Any(a => a.AttributeClass?.IsGodotSignalAttribute() ?? false))
{
context.ReportSuppression(Suppression.Create(_descriptor, diagnostic));
}
}
}
}