From a3fe028809f805b19c41683087427e7d88440519 Mon Sep 17 00:00:00 2001 From: George Marques Date: Wed, 9 Feb 2022 09:07:18 -0300 Subject: [PATCH] GDScript: Infer variable types on release Otherwise this creates an inconsistency between debug and release builds, potentially leading to crashes. --- modules/gdscript/gdscript_parser.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/modules/gdscript/gdscript_parser.cpp b/modules/gdscript/gdscript_parser.cpp index 34e37693e8c..0c5f5d29ccc 100644 --- a/modules/gdscript/gdscript_parser.cpp +++ b/modules/gdscript/gdscript_parser.cpp @@ -2943,9 +2943,7 @@ void GDScriptParser::_parse_block(BlockNode *p_block, bool p_static) { if (tokenizer->get_token() == GDScriptTokenizer::TK_COLON) { if (tokenizer->get_token(1) == GDScriptTokenizer::TK_OP_ASSIGN) { lv->datatype = DataType(); -#ifdef DEBUG_ENABLED lv->datatype.infer_type = true; -#endif tokenizer->advance(); } else if (!_parse_type(lv->datatype)) { _set_error("Expected a type for the variable."); @@ -4905,9 +4903,7 @@ void GDScriptParser::_parse_class(ClassNode *p_class) { if (tokenizer->get_token() == GDScriptTokenizer::TK_COLON) { if (tokenizer->get_token(1) == GDScriptTokenizer::TK_OP_ASSIGN) { member.data_type = DataType(); -#ifdef DEBUG_ENABLED member.data_type.infer_type = true; -#endif tokenizer->advance(); } else if (!_parse_type(member.data_type)) { _set_error("Expected a type for the class variable."); @@ -5149,9 +5145,7 @@ void GDScriptParser::_parse_class(ClassNode *p_class) { if (tokenizer->get_token() == GDScriptTokenizer::TK_COLON) { if (tokenizer->get_token(1) == GDScriptTokenizer::TK_OP_ASSIGN) { constant.type = DataType(); -#ifdef DEBUG_ENABLED constant.type.infer_type = true; -#endif tokenizer->advance(); } else if (!_parse_type(constant.type)) { _set_error("Expected a type for the class constant.");