asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevents shader crash if passing invalid struct to the return statement

Browse source
This commit is contained in:
Yuri Roubinsky 2021-02-21 07:35:09 +03:00 committed by Lyuma
parent ae8de1f2ce
commit ac547031d5
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
servers/visual/shader_language.cpp
View file

@ -5335,6 +5335,8 @@ Error ShaderLanguage::_parse_block(BlockNode *p_block, const Map<StringName, Bui
return ERR_BUG; return ERR_BUG;
} }
String return_struct_name = String(b->parent_function->return_struct_name);
ControlFlowNode *flow = alloc_node<ControlFlowNode>(); ControlFlowNode *flow = alloc_node<ControlFlowNode>();
flow->flow_op = FLOW_OP_RETURN; flow->flow_op = FLOW_OP_RETURN;
@ -5343,7 +5345,7 @@ Error ShaderLanguage::_parse_block(BlockNode *p_block, const Map<StringName, Bui
if (tk.type == TK_SEMICOLON) { if (tk.type == TK_SEMICOLON) {
//all is good //all is good
if (b->parent_function->return_type != TYPE_VOID) { if (b->parent_function->return_type != TYPE_VOID) {
_set_error("Expected return with expression of type '" + get_datatype_name(b->parent_function->return_type) + "'"); _set_error("Expected return with an expression of type '" + (return_struct_name != "" ? return_struct_name : get_datatype_name(b->parent_function->return_type)) + "'");
return ERR_PARSE_ERROR; return ERR_PARSE_ERROR;
} }
} else { } else {
@ -5353,8 +5355,8 @@ Error ShaderLanguage::_parse_block(BlockNode *p_block, const Map<StringName, Bui
return ERR_PARSE_ERROR; return ERR_PARSE_ERROR;
} }
if (b->parent_function->return_type != expr->get_datatype()) { if (b->parent_function->return_type != expr->get_datatype() || return_struct_name != expr->get_datatype_name()) {
_set_error("Expected return expression of type '" + get_datatype_name(b->parent_function->return_type) + "'"); _set_error("Expected return with an expression of type '" + (return_struct_name != "" ? return_struct_name : get_datatype_name(b->parent_function->return_type)) + "'");
return ERR_PARSE_ERROR; return ERR_PARSE_ERROR;
} }