asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #71528 from snakept/missing-path-external-editor-error

Browse source 
Checking path variable if empty before opening external editor to fix…
This commit is contained in:
Rémi Verschelde 2023-01-17 17:30:58 +01:00
commit ae766558f0
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
editor/plugins/script_editor_plugin.cpp
View file

@ -2256,11 +2256,14 @@ bool ScriptEditor::edit(const Ref<Resource> &p_resource, int p_line, int p_col,
args.push_back(script_path);
}
Error err = OS::get_singleton()->create_process(path, args);
if (err == OK) {
return false;
if (!path.is_empty()) {
Error err = OS::get_singleton()->create_process(path, args);
if (err == OK) {
return false;
}
}
WARN_PRINT("Couldn't open external text editor, using internal");
ERR_PRINT("Couldn't open external text editor, falling back to the internal editor. Review your `text_editor/external/` editor settings.");
}
for (int i = 0; i < tab_container->get_tab_count(); i++) {