From d66c7a2ac52a43bba99d33eef0bbf42fe795f3d0 Mon Sep 17 00:00:00 2001 From: Chia-Hsiang Cheng Date: Sun, 23 Jul 2023 18:03:38 +0800 Subject: [PATCH] Ensure the 'select_all' function selects all items --- scene/gui/rich_text_label.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scene/gui/rich_text_label.cpp b/scene/gui/rich_text_label.cpp index 070c79c0ee1..2c98cb5a28b 100644 --- a/scene/gui/rich_text_label.cpp +++ b/scene/gui/rich_text_label.cpp @@ -5304,6 +5304,8 @@ void RichTextLabel::selection_copy() { } void RichTextLabel::select_all() { + _validate_line_caches(); + if (!selection.enabled) { return; } @@ -5316,13 +5318,12 @@ void RichTextLabel::select_all() { if (it->type != ITEM_FRAME) { if (!from_item) { from_item = it; - } else { - to_item = it; } + to_item = it; } it = _get_next_item(it, true); } - if (!from_item || !to_item) { + if (!from_item) { return; }