asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Web: Workaround Emscripten 3.1.42+ LTO regression

Browse source 
Fixes #80010.
This commit is contained in:
Rémi Verschelde 2023-09-05 14:56:53 +02:00
parent e7208420bc
commit b064008c07
No known key found for this signature in database
GPG key ID: C3336907360768E1
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/web_builds.yml vendored
View file

@ -7,7 +7,7 @@ env:
# Used for the cache key. Add version suffix to force clean build. # Used for the cache key. Add version suffix to force clean build.
GODOT_BASE_BRANCH: master GODOT_BASE_BRANCH: master
SCONSFLAGS: verbose=yes warnings=extra werror=yes debug_symbols=no SCONSFLAGS: verbose=yes warnings=extra werror=yes debug_symbols=no
EM_VERSION: 3.1.18 EM_VERSION: 3.1.45
EM_CACHE_FOLDER: "emsdk-cache" EM_CACHE_FOLDER: "emsdk-cache"
concurrency: concurrency:
@ -16,7 +16,7 @@ concurrency:
jobs: jobs:
web-template: web-template:
runs-on: "ubuntu-20.04" runs-on: "ubuntu-22.04"
name: Template (target=template_release) name: Template (target=template_release)
steps: steps:

5
platform/web/detect.py
View file

@ -118,6 +118,11 @@ def configure(env: "Environment"):
else: else:
env.Append(CCFLAGS=["-flto"]) env.Append(CCFLAGS=["-flto"])
env.Append(LINKFLAGS=["-flto"]) env.Append(LINKFLAGS=["-flto"])
# Workaround https://github.com/emscripten-core/emscripten/issues/19781.
cc_version = get_compiler_version(env)
cc_semver = (int(cc_version["major"]), int(cc_version["minor"]), int(cc_version["patch"]))
if cc_semver >= (3, 1, 42):
env.Append(LINKFLAGS=["-Wl,-u,scalbnf"])
# Sanitizers # Sanitizers
if env["use_ubsan"]: if env["use_ubsan"]: