asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #49073 from pfertyk/issue-49006-packedbytearray-decompress-crashes-godot

Browse source 
Return error when decompressing empty PackedByteArray
This commit is contained in:
Rémi Verschelde 2021-05-25 21:17:48 +02:00 committed by GitHub
commit b6f381475f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/variant/variant_call.cpp
View file

@ -611,6 +611,9 @@ struct _VariantCall {
if (buffer_size <= 0) { if (buffer_size <= 0) {
ERR_FAIL_V_MSG(decompressed, "Decompression buffer size must be greater than zero."); ERR_FAIL_V_MSG(decompressed, "Decompression buffer size must be greater than zero.");
} }
if (p_instance->size() == 0) {
ERR_FAIL_V_MSG(decompressed, "Compressed buffer size must be greater than zero.");
}
decompressed.resize(buffer_size); decompressed.resize(buffer_size);
int result = Compression::decompress(decompressed.ptrw(), buffer_size, p_instance->ptr(), p_instance->size(), mode); int result = Compression::decompress(decompressed.ptrw(), buffer_size, p_instance->ptr(), p_instance->size(), mode);