asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #45220 from Calinou/range-ratio-equal-min-max-no-error

Browse source 
Make Range return 1.0 ratio if minimum and maximum values are equal
This commit is contained in:
Rémi Verschelde 2021-01-26 15:24:58 +01:00 committed by GitHub
commit b84729f848
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
scene/gui/range.cpp
View file

@ -171,7 +171,10 @@ void Range::set_as_ratio(double p_value) {
} }
double Range::get_as_ratio() const { double Range::get_as_ratio() const {
ERR_FAIL_COND_V_MSG(Math::is_equal_approx(get_max(), get_min()), 0.0, "Cannot get ratio when minimum and maximum value are equal."); if (Math::is_equal_approx(get_max(), get_min())) {
// Avoid division by zero.
return 1.0;
}
if (shared->exp_ratio && get_min() >= 0) { if (shared->exp_ratio && get_min() >= 0) {
double exp_min = get_min() == 0 ? 0.0 : Math::log(get_min()) / Math::log((double)2); double exp_min = get_min() == 0 ? 0.0 : Math::log(get_min()) / Math::log((double)2);