asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #6637 from Zylann/windows_print_overflow

Browse source 
Windows: prevent huge prints from crashing the engine
This commit is contained in:
Rémi Verschelde 2016-09-29 09:31:52 +02:00 committed by GitHub
commit b8c60636db
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
platform/windows/os_windows.cpp
View file

@ -1312,10 +1312,13 @@ void OS_Windows::finalize_core() {
void OS_Windows::vprint(const char* p_format, va_list p_list, bool p_stderr) { void OS_Windows::vprint(const char* p_format, va_list p_list, bool p_stderr) {
char buf[16384+1]; const unsigned int BUFFER_SIZE = 16384;
int len = vsnprintf(buf,16384,p_format,p_list); char buf[BUFFER_SIZE+1]; // +1 for the terminating character
int len = vsnprintf(buf,BUFFER_SIZE,p_format,p_list);
if (len<=0) if (len<=0)
return; return;
if(len >= BUFFER_SIZE)
len = BUFFER_SIZE; // Output is too big, will be truncated
buf[len]=0; buf[len]=0;