asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #93908 from Geometror/ge-resized-fix

Browse source 
Fix `Control` nodes emitting unnecessary `resized` signals
This commit is contained in:
Rémi Verschelde 2024-07-05 16:38:10 +02:00 committed by GitHub
commit b97110cd30
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
scene/gui/control.cpp
View file

@ -1732,11 +1732,15 @@ void Control::_size_changed() {
new_size_cache.height = minimum_size.height;
}
bool pos_changed = new_pos_cache != data.pos_cache;
bool size_changed = new_size_cache != data.size_cache;
bool pos_changed = !new_pos_cache.is_equal_approx(data.pos_cache);
bool size_changed = !new_size_cache.is_equal_approx(data.size_cache);
if (pos_changed) {
data.pos_cache = new_pos_cache;
}
if (size_changed) {
data.size_cache = new_size_cache;
}
if (is_inside_tree()) {
if (pos_changed || size_changed) {
@ -1751,14 +1755,12 @@ void Control::_size_changed() {
}
if (pos_changed && !size_changed) {
_update_canvas_item_transform(); //move because it won't be updated
_update_canvas_item_transform();
}
} else {
if (pos_changed) {
} else if (pos_changed) {
_notify_transform();
}
}
}
void Control::_clear_size_warning() {
data.size_warning = false;