asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Force unsigned behaviour for bitfield enums

Browse source 
Some compilers (notably MSVC) were using signed values for bitfield enums. This was causing problems where 2 bits were used to store 4 or less enum values, where they were being treated as negative numbers.

This PR explicitly requests these enums to be treated as unsigned values.
This commit is contained in:
lawnjelly 2022-06-06 16:58:21 +01:00
parent b48a589a45
commit ba74643594
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/math/transform_interpolator.h
View file

@ -50,7 +50,7 @@ class Transform;
class TransformInterpolator {
public:
enum Method {
enum Method : unsigned int {
INTERP_LERP,
INTERP_SLERP,
INTERP_SCALED_SLERP,

8
scene/main/node.h
View file

@ -48,14 +48,18 @@ class Node : public Object {
OBJ_CATEGORY("Nodes");
public:
enum PauseMode {
// N.B. Any enum stored as a bitfield should
// be specified as UNSIGNED to work around
// some compilers trying to store it as signed,
// and requiring 1 more bit than necessary.
enum PauseMode : unsigned int {
PAUSE_MODE_INHERIT,
PAUSE_MODE_STOP,
PAUSE_MODE_PROCESS
};
enum PhysicsInterpolationMode {
enum PhysicsInterpolationMode : unsigned int {
PHYSICS_INTERPOLATION_MODE_INHERIT,
PHYSICS_INTERPOLATION_MODE_OFF,