From 4c5ceb1a97324a0293c1334faa2eb4bc5855644c Mon Sep 17 00:00:00 2001 From: Johannes Witt Date: Thu, 6 Jan 2022 22:01:01 +0100 Subject: [PATCH] Rename GraphEdit connection_drag_begun to connection_drag_started --- doc/classes/GraphEdit.xml | 14 +++++++------- scene/gui/graph_edit.cpp | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/classes/GraphEdit.xml b/doc/classes/GraphEdit.xml index be6d9e07c30..46960d7cc46 100644 --- a/doc/classes/GraphEdit.xml +++ b/doc/classes/GraphEdit.xml @@ -113,7 +113,7 @@ Ends the creation of the current connection. In other words, if you are dragging a connection you can use this method to abort the process and remove the line that followed your cursor. - This is best used together with [signal connection_drag_begun] and [signal connection_drag_ended] to add custom behavior like node addition through shortcuts. + This is best used together with [signal connection_drag_started] and [signal connection_drag_ended] to add custom behavior like node addition through shortcuts. [b]Note:[/b] This method suppresses any other connection request signals apart from [signal connection_drag_ended]. @@ -249,7 +249,12 @@ Emitted at the beginning of a GraphNode movement. - + + + Emitted at the end of a connection drag. + + + @@ -257,11 +262,6 @@ Emitted at the beginning of a connection drag. - - - Emitted at the end of a connection drag. - - diff --git a/scene/gui/graph_edit.cpp b/scene/gui/graph_edit.cpp index 92c770429b9..df9bb7407a4 100644 --- a/scene/gui/graph_edit.cpp +++ b/scene/gui/graph_edit.cpp @@ -600,7 +600,7 @@ void GraphEdit::_top_layer_input(const Ref &p_ev) { to = get_node(String(connecting_from)); //maybe it was erased if (Object::cast_to(to)) { connecting = true; - emit_signal(SNAME("connection_drag_begun"), connecting_from, connecting_index, false); + emit_signal(SNAME("connection_drag_started"), connecting_from, connecting_index, false); } return; } @@ -617,7 +617,7 @@ void GraphEdit::_top_layer_input(const Ref &p_ev) { connecting_target = false; connecting_to = pos; just_disconnected = false; - emit_signal(SNAME("connection_drag_begun"), connecting_from, connecting_index, true); + emit_signal(SNAME("connection_drag_started"), connecting_from, connecting_index, true); return; } } @@ -644,7 +644,7 @@ void GraphEdit::_top_layer_input(const Ref &p_ev) { fr = get_node(String(connecting_from)); //maybe it was erased if (Object::cast_to(fr)) { connecting = true; - emit_signal(SNAME("connection_drag_begun"), connecting_from, connecting_index, true); + emit_signal(SNAME("connection_drag_started"), connecting_from, connecting_index, true); } return; } @@ -661,7 +661,7 @@ void GraphEdit::_top_layer_input(const Ref &p_ev) { connecting_target = false; connecting_to = pos; just_disconnected = false; - emit_signal(SNAME("connection_drag_begun"), connecting_from, connecting_index, false); + emit_signal(SNAME("connection_drag_started"), connecting_from, connecting_index, false); return; } } @@ -2273,7 +2273,7 @@ void GraphEdit::_bind_methods() { ADD_SIGNAL(MethodInfo("begin_node_move")); ADD_SIGNAL(MethodInfo("end_node_move")); ADD_SIGNAL(MethodInfo("scroll_offset_changed", PropertyInfo(Variant::VECTOR2, "ofs"))); - ADD_SIGNAL(MethodInfo("connection_drag_begun", PropertyInfo(Variant::STRING, "from"), PropertyInfo(Variant::STRING, "slot"), PropertyInfo(Variant::BOOL, "is_output"))); + ADD_SIGNAL(MethodInfo("connection_drag_started", PropertyInfo(Variant::STRING, "from"), PropertyInfo(Variant::STRING, "slot"), PropertyInfo(Variant::BOOL, "is_output"))); ADD_SIGNAL(MethodInfo("connection_drag_ended")); }