Save the current script when pressing Ctrl + S if no scene is open
- Tweak the dialog messages to be more informative.
- The "Saved N modified resources" dialog is not a warning per se,
so make it more explicit.
(cherry picked from commit 39f9b92f54
)
This commit is contained in:
parent
c1e887edb8
commit
c318cf6ed2
3 changed files with 53 additions and 44 deletions
|
@ -2352,15 +2352,24 @@ void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) {
|
|||
Node *scene = editor_data.get_edited_scene_root(scene_idx);
|
||||
|
||||
if (!scene) {
|
||||
int saved = _save_external_resources();
|
||||
String err_text;
|
||||
if (saved > 0) {
|
||||
err_text = vformat(TTR("Saved %s modified resource(s)."), itos(saved));
|
||||
} else {
|
||||
err_text = TTR("A root node is required to save the scene.");
|
||||
if (p_option == FILE_SAVE_SCENE) {
|
||||
// Pressing Ctrl + S saves the current script if a scene is currently open, but it won't if the scene has no root node.
|
||||
// Work around this by explicitly saving the script in this case (similar to pressing Ctrl + Alt + S).
|
||||
ScriptEditor::get_singleton()->save_current_script();
|
||||
}
|
||||
|
||||
const int saved = _save_external_resources();
|
||||
if (saved > 0) {
|
||||
show_accept(
|
||||
vformat(TTR("The current scene has no root node, but %d modified external resource(s) were saved anyway."), saved),
|
||||
TTR("OK"));
|
||||
} else if (p_option == FILE_SAVE_AS_SCENE) {
|
||||
// Don't show this dialog when pressing Ctrl + S to avoid interfering with script saving.
|
||||
show_accept(
|
||||
TTR("A root node is required to save the scene. You can add a root node using the Scene tree dock."),
|
||||
TTR("OK"));
|
||||
}
|
||||
|
||||
show_accept(err_text, TTR("OK"));
|
||||
break;
|
||||
}
|
||||
|
||||
|
|
|
@ -551,7 +551,7 @@ void ScriptEditor::_close_tab(int p_idx, bool p_save, bool p_history_back) {
|
|||
if (p_save) {
|
||||
// Do not try to save internal scripts
|
||||
if (!script.is_valid() || !(script->get_path() == "" || script->get_path().find("local://") != -1 || script->get_path().find("::") != -1)) {
|
||||
_save_current_script();
|
||||
save_current_script();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -948,39 +948,6 @@ bool ScriptEditor::is_scripts_panel_toggled() {
|
|||
return list_split->is_visible();
|
||||
}
|
||||
|
||||
void ScriptEditor::_save_current_script() {
|
||||
ScriptEditorBase *current = _get_current_editor();
|
||||
|
||||
if (_test_script_times_on_disk()) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (trim_trailing_whitespace_on_save) {
|
||||
current->trim_trailing_whitespace();
|
||||
}
|
||||
|
||||
current->insert_final_newline();
|
||||
|
||||
if (convert_indent_on_save) {
|
||||
if (use_space_indentation) {
|
||||
current->convert_indent_to_spaces();
|
||||
} else {
|
||||
current->convert_indent_to_tabs();
|
||||
}
|
||||
}
|
||||
|
||||
RES resource = current->get_edited_resource();
|
||||
Ref<TextFile> text_file = resource;
|
||||
|
||||
if (text_file != nullptr) {
|
||||
current->apply_code();
|
||||
_save_text_file(text_file, text_file->get_path());
|
||||
return;
|
||||
}
|
||||
|
||||
editor->save_resource(resource);
|
||||
}
|
||||
|
||||
void ScriptEditor::_menu_option(int p_option) {
|
||||
ScriptEditorBase *current = _get_current_editor();
|
||||
switch (p_option) {
|
||||
|
@ -1122,7 +1089,7 @@ void ScriptEditor::_menu_option(int p_option) {
|
|||
if (current) {
|
||||
switch (p_option) {
|
||||
case FILE_SAVE: {
|
||||
_save_current_script();
|
||||
save_current_script();
|
||||
} break;
|
||||
case FILE_SAVE_AS: {
|
||||
if (trim_trailing_whitespace_on_save) {
|
||||
|
@ -2182,6 +2149,39 @@ bool ScriptEditor::edit(const RES &p_resource, int p_line, int p_col, bool p_gra
|
|||
return true;
|
||||
}
|
||||
|
||||
void ScriptEditor::save_current_script() {
|
||||
ScriptEditorBase *current = _get_current_editor();
|
||||
|
||||
if (_test_script_times_on_disk()) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (trim_trailing_whitespace_on_save) {
|
||||
current->trim_trailing_whitespace();
|
||||
}
|
||||
|
||||
current->insert_final_newline();
|
||||
|
||||
if (convert_indent_on_save) {
|
||||
if (use_space_indentation) {
|
||||
current->convert_indent_to_spaces();
|
||||
} else {
|
||||
current->convert_indent_to_tabs();
|
||||
}
|
||||
}
|
||||
|
||||
RES resource = current->get_edited_resource();
|
||||
Ref<TextFile> text_file = resource;
|
||||
|
||||
if (text_file != nullptr) {
|
||||
current->apply_code();
|
||||
_save_text_file(text_file, text_file->get_path());
|
||||
return;
|
||||
}
|
||||
|
||||
editor->save_resource(resource);
|
||||
}
|
||||
|
||||
void ScriptEditor::save_all_scripts() {
|
||||
for (int i = 0; i < tab_container->get_child_count(); i++) {
|
||||
ScriptEditorBase *se = Object::cast_to<ScriptEditorBase>(tab_container->get_child(i));
|
||||
|
@ -2292,7 +2292,7 @@ void ScriptEditor::_add_callback(Object *p_obj, const String &p_function, const
|
|||
script_list->select(script_list->find_metadata(i));
|
||||
|
||||
// Save the current script so the changes can be picked up by an external editor.
|
||||
_save_current_script();
|
||||
save_current_script();
|
||||
|
||||
break;
|
||||
}
|
||||
|
|
|
@ -276,7 +276,6 @@ class ScriptEditor : public PanelContainer {
|
|||
|
||||
String _get_debug_tooltip(const String &p_text, Node *_se);
|
||||
|
||||
void _save_current_script();
|
||||
void _resave_scripts(const String &p_str);
|
||||
void _reload_scripts();
|
||||
|
||||
|
@ -428,6 +427,7 @@ public:
|
|||
|
||||
void get_breakpoints(List<String> *p_breakpoints);
|
||||
|
||||
void save_current_script();
|
||||
void save_all_scripts();
|
||||
|
||||
void set_window_layout(Ref<ConfigFile> p_layout);
|
||||
|
|
Loading…
Reference in a new issue