From c58b1608ea81af0327d846e8537f5821444241e0 Mon Sep 17 00:00:00 2001 From: Hein-Pieter van Braam Date: Mon, 17 Dec 2018 22:31:02 +0100 Subject: [PATCH] Don't accidentally convert string content to char Due to the right hand side of the :? trickery the rhs was cast to a char losing precision. Previously this didn't matter, but with CharProxy it does. (Previously we could just happily cast it back to a wchar_t and get the original 16 - 32 bits. Now we'll only ever get the first 8). --- scene/gui/label.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scene/gui/label.cpp b/scene/gui/label.cpp index a7f88514e02..1b7196c4020 100644 --- a/scene/gui/label.cpp +++ b/scene/gui/label.cpp @@ -395,7 +395,7 @@ void Label::regenerate_word_cache() { for (int i = 0; i <= xl_text.length(); i++) { - CharType current = i < xl_text.length() ? xl_text[i] : ' '; //always a space at the end, so the algo works + CharType current = i < xl_text.length() ? xl_text[i] : L' '; //always a space at the end, so the algo works if (uppercase) current = String::char_uppercase(current);