From c6617e956ce1f36c72f714f8dd4ef697127c50fb Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Fri, 1 Oct 2021 16:38:37 +0200 Subject: [PATCH] =?UTF-8?q?Tweak=20the=20Viewport=20configuration=20warnin?= =?UTF-8?q?g=20to=20mention=202=C3=972=20size=20requirement?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- doc/classes/Viewport.xml | 2 +- scene/main/viewport.cpp | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/classes/Viewport.xml b/doc/classes/Viewport.xml index 5580d857507..72ae06bbb7a 100644 --- a/doc/classes/Viewport.xml +++ b/doc/classes/Viewport.xml @@ -272,7 +272,7 @@ If set to a value greater than [code]0.0[/code], contrast-adaptive sharpening will be applied to the 3D viewport. This has a low performance cost and can be used to recover some of the sharpness lost from using FXAA. Values around [code]0.5[/code] generally give the best results. See also [member fxaa]. - The width and height of viewport. + The width and height of viewport. Must be set to a value greater than or equal to 2 pixels on both dimensions. Otherwise, nothing will be displayed. If [code]true[/code], the size override affects stretch as well. diff --git a/scene/main/viewport.cpp b/scene/main/viewport.cpp index dcc114cc4da..99f9146ab14 100644 --- a/scene/main/viewport.cpp +++ b/scene/main/viewport.cpp @@ -720,6 +720,7 @@ void Viewport::set_size(const Size2 &p_size) { VS::get_singleton()->viewport_set_size(viewport, size.width, size.height); _update_stretch_transform(); + update_configuration_warning(); emit_signal("size_changed"); } @@ -2935,11 +2936,11 @@ String Viewport::get_configuration_warning() const { String warning = Node::get_configuration_warning(); - if (size.x == 0 || size.y == 0) { + if (size.x <= 1 || size.y <= 1) { if (warning != String()) { warning += "\n\n"; } - warning += TTR("Viewport size must be greater than 0 to render anything."); + warning += TTR("The Viewport size must be greater than or equal to 2 pixels on both dimensions to render anything."); } return warning; }