asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #89502 from kleonc/control-set-global-position-fix

Browse source 
Fix `Control::set_global_position` for rotated/scaled transforms
This commit is contained in:
Rémi Verschelde 2024-03-15 10:40:14 +01:00
commit c7061d5e96
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
scene/gui/control.cpp
View file

@ -1406,15 +1406,11 @@ void Control::_set_global_position(const Point2 &p_point) {
void Control::set_global_position(const Point2 &p_point, bool p_keep_offsets) {
ERR_MAIN_THREAD_GUARD;
Transform2D global_transform_cache = get_global_transform();
if (p_point == global_transform_cache.get_origin()) {
return; // Edge case, but avoids calculation.
}
Point2 internal_position = global_transform_cache.affine_inverse().xform(p_point);
set_position(internal_position + data.pos_cache, p_keep_offsets);
// (parent_global_transform * T(new_position) * internal_transform).origin == new_global_position
// (T(new_position) * internal_transform).origin == new_position_in_parent_space
// new_position == new_position_in_parent_space - internal_transform.origin
Point2 position_in_parent_space = data.parent_canvas_item ? data.parent_canvas_item->get_global_transform().affine_inverse().xform(p_point) : p_point;
set_position(position_in_parent_space - _get_internal_transform().get_origin(), p_keep_offsets);
}
Point2 Control::get_global_position() const {