From ad15edbc6560343137e11e2b5f69b8fe871a4bf9 Mon Sep 17 00:00:00 2001 From: nathanwfranke Date: Thu, 20 Feb 2020 18:37:35 -0600 Subject: [PATCH] Partial revert "Fix two signal errors" This partially reverts commit a31bc1b0ba608ef340068676f6709621a37f2140. Possible compatibility issues with #35864 that I am not sure about. Do I need to change "connect" to "connect_compat"? --- editor/plugins/canvas_item_editor_plugin.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/editor/plugins/canvas_item_editor_plugin.cpp b/editor/plugins/canvas_item_editor_plugin.cpp index dfcaf5cdd25..72772e5ceb7 100644 --- a/editor/plugins/canvas_item_editor_plugin.cpp +++ b/editor/plugins/canvas_item_editor_plugin.cpp @@ -5413,8 +5413,8 @@ CanvasItemEditor::CanvasItemEditor(EditorNode *p_editor) { editor_selection->connect_compat("selection_changed", this, "update"); editor_selection->connect_compat("selection_changed", this, "_selection_changed"); - editor->call_deferred("connect", make_binds("play_pressed", Callable(this, "_update_override_camera_button"), true)); - editor->call_deferred("connect", make_binds("stop_pressed", Callable(this, "_update_override_camera_button"), false)); + editor->call_deferred("connect", "play_pressed", Callable(this, "_update_override_camera_button"), make_binds(true)); + editor->call_deferred("connect", "stop_pressed", Callable(this, "_update_override_camera_button"), make_binds(false)); hb = memnew(HBoxContainer); add_child(hb);