asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #34048 from KoBeWi/center_of_the_bookmark

Browse source 
Center Script Editor when jumping to bookmarks/breakpoints
This commit is contained in:
Rémi Verschelde 2019-12-01 22:20:31 +01:00 committed by GitHub
commit d2858e2371
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
editor/code_editor.cpp
View file

@ -1565,6 +1565,7 @@ void CodeTextEditor::goto_next_bookmark() {
if (bline > line) { if (bline > line) {
text_editor->unfold_line(bline); text_editor->unfold_line(bline);
text_editor->cursor_set_line(bline); text_editor->cursor_set_line(bline);
text_editor->center_viewport_to_cursor();
return; return;
} }
} }
@ -1589,6 +1590,7 @@ void CodeTextEditor::goto_prev_bookmark() {
if (bline < line) { if (bline < line) {
text_editor->unfold_line(bline); text_editor->unfold_line(bline);
text_editor->cursor_set_line(bline); text_editor->cursor_set_line(bline);
text_editor->center_viewport_to_cursor();
return; return;
} }
} }

4
editor/plugins/script_text_editor.cpp
View file

@ -707,6 +707,7 @@ void ScriptTextEditor::_bookmark_item_pressed(int p_idx) {
_edit_option(bookmarks_menu->get_item_id(p_idx)); _edit_option(bookmarks_menu->get_item_id(p_idx));
} else { } else {
code_editor->goto_line(bookmarks_menu->get_item_metadata(p_idx)); code_editor->goto_line(bookmarks_menu->get_item_metadata(p_idx));
code_editor->get_text_edit()->call_deferred("center_viewport_to_cursor"); //Need to be deferred, because goto uses call_deferred().
} }
} }
@ -856,6 +857,7 @@ void ScriptTextEditor::_breakpoint_item_pressed(int p_idx) {
_edit_option(breakpoints_menu->get_item_id(p_idx)); _edit_option(breakpoints_menu->get_item_id(p_idx));
} else { } else {
code_editor->goto_line(breakpoints_menu->get_item_metadata(p_idx)); code_editor->goto_line(breakpoints_menu->get_item_metadata(p_idx));
code_editor->get_text_edit()->call_deferred("center_viewport_to_cursor"); //Need to be deferred, because goto uses call_deferred().
} }
} }
@ -1307,6 +1309,7 @@ void ScriptTextEditor::_edit_option(int p_op) {
if (bline > line) { if (bline > line) {
tx->unfold_line(bline); tx->unfold_line(bline);
tx->cursor_set_line(bline); tx->cursor_set_line(bline);
tx->center_viewport_to_cursor();
return; return;
} }
} }
@ -1332,6 +1335,7 @@ void ScriptTextEditor::_edit_option(int p_op) {
if (bline < line) { if (bline < line) {
tx->unfold_line(bline); tx->unfold_line(bline);
tx->cursor_set_line(bline); tx->cursor_set_line(bline);
tx->center_viewport_to_cursor();
return; return;
} }
} }